Issue #3323 has been updated by Daniel Pittman. Status changed from Tests Insufficient to Code Insufficient
Given that this only supports one choice, `stop/start`, `restart`, `reload`, or `graceful`, it seems highly counter-intuitive that you would have to pick *one* of multiple boolean values. It would, I think, make a great deal more sense recast as a single multi-value field that allowed the selection between them. That also avoids the obvious failure mode, which is that someone accidentally sets two of the fields true, resulting in unspecified behaviour. (I would object less if the change treated setting multiple values as a hard error, which it does not.) However, it seems to me that this change is likely really wanting to have a richer set of notification semantics for services, rather than wanting to be able to hard-code the type of restart, no? In that case, is this actually a valuable intermediate step? ---------------------------------------- Feature #3323: Create hasreload similar to hasrestart https://projects.puppetlabs.com/issues/3323 Author: Chuck McIntyre Status: Code Insufficient Priority: Normal Assignee: Chuck McIntyre Category: service Target version: Telly Affected Puppet version: 0.24.8 Keywords: hasreload, service Branch: https://github.com/jamtur01/puppet/tree/tickets/master/3323 Many init scripts allow for a "reload" option in addition to a restart and a stop/start. It would be useful if this could be defined for a given service generically, rather than having to resort to an Exec resource or other workaround for cases where we want to reload instead of restart (an example could be made using apache or bind configuration changes). I am attaching an example diff (note this is not a patch, nor has it been tested) to describe in more detail how this might be accomplished. I am willing to submit a patch for this if the feature is accepted. I would like some guidance as to whether the existing unit test modifications are sufficient or if it is necessary to test that (at least) reload and restart get called appropriately (not simply that stop/start get called when not specified). -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
