Issue #8279 has been updated by Ken Barber.
Status changed from In Topic Branch Pending Review to Tests Insufficient
We have no test coverage for these facts ... any chance of at least getting
coverage for this case? It would also make code changes easier to understand as
well if you can provide fixtures or something containing sample return content.
I'd like to see the meta data in a test to understand the use-case better and
how it needs to be presented in the EC2 metadata sections to support these
'arrays' :-).
Also - what are the consequences of fixing this on the maintenance branch? It
seems to me based on this code, we are going from a case where the elements
were munged with no delimiter:
value = value.size>1 ? value : value.first
To all values with commas separated:
Facter.add(symbol) { setcode { value.join(',') } }
Is my interpretation of the problem correct?
Will this break some users code? - I'm just wary. Or have arrays been so broken
up until now it has been unusable anyway and is worth a 1.6.x fix. (/me playing
devils advocate :-)
----------------------------------------
Bug #8279: ec2_security_groups concatenates multiple groups instead of
separating by a comma
https://projects.puppetlabs.com/issues/8279
Author: Michael Halligan
Status: Tests Insufficient
Priority: Normal
Assignee: Adrien Thebo
Category: library
Target version:
Keywords:
Branch:
https://github.com/adrienthebo/facter/tree/ticket/1.6.x/8279-ec2_join_facts_with_comma
Affected Facter version: 1.6.0
When you run facter on an ec2 node, the ec2_security_groups fact joins all of
the groups a node belongs to. Separating by a , or even a space would make this
fact much easier to act on.
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en.
