Issue #7138 has been updated by Ken Barber. Status changed from In Topic Branch Pending Review to Code Insufficient
As Josh says - the use of cat for proc in virtual.rb has to stay. The other fixes are good - cheers. If you can remove that virtual.rb change and submit a pull request from your branch that would be great. If you have some time - we would really like some test coverage for these cases as well :-). As currently we have no coverage which is not so great: https://github.com/puppetlabs/facter/blob/1.6.x/spec/unit/operatingsystemrelease_spec.rb ---------------------------------------- Bug #7138: Facter use exec + cat ( or exec = hostname ) when not needed https://projects.puppetlabs.com/issues/7138 Author: Michael Scherer Status: Code Insufficient Priority: Low Assignee: Category: interface Target version: 1.6.x Keywords: Branch: https://github.com/mscherer/facter/tree/ticket/1.5.x/7138 Affected Facter version: In various place in the code, facter use Facter::Util::Resolution.exec while this could be avoided, most notably when reading file with cat. I have patches that I can split if needed to use either ruby functions ( for hostname ), or File::open. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
