Issue #8279 has been updated by Hunter Haugen.
Afaict, arrays haven't been /very/ broken, but the way the code was written would cause the `read` `value` to be an array of 1 or more length; if it was 1-length array then we un-array it by `.first`, otherwise we return the whole array, which would be joined without a delimiter (hence the glomming of security groups). With this code commit, the join works on one-or-more length arrays, either returning the single item, or all items joined with commas. So single-item arrays will return the same value as previously, and multi-item arrays will now be comma delineated. This change should be only value-add, and no backwards breaking. Test coverage would still be nice. ---------------------------------------- Bug #8279: ec2_security_groups concatenates multiple groups instead of separating by a comma https://projects.puppetlabs.com/issues/8279 Author: Michael Halligan Status: Tests Insufficient Priority: Normal Assignee: Adrien Thebo Category: library Target version: 1.6.x Keywords: Branch: https://github.com/adrienthebo/facter/tree/ticket/1.6.x/8279-ec2_join_facts_with_comma Affected Facter version: 1.6.0 When you run facter on an ec2 node, the ec2_security_groups fact joins all of the groups a node belongs to. Separating by a , or even a space would make this fact much easier to act on. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
