Issue #11196 has been updated by Ken Barber.

Huh. <insert stunned look>.

    commit acf0bb21c88edb0eacf4ab73402614c721cf2f76
    Author: Ohad Levy <[email protected]>
    Date:   Tue Mar 22 23:04:23 2011 +0200

        Ensures that ARP facts are returned only on EC2 hosts
    
        ARP facts on large network might lead to inconstant values
        as we are always using the first ARP entry from the output of the ARP
        command
    
        Signed-off-by: Ohad Levy <[email protected]>

James,

So this change to the arp handling was merged in by yourself I think 
(d5bec9713ba31746fb4de631ea5afb9a9453e3b2) but it doesn't seem right to me. 
What are your thoughts on this? I was about to suggest traversing all the facts 
(ie. arp_<interface> style) to work around Pieter's bug but it looks like these 
were limited to EC2 only as well ... would you say this is in error? I can kind 
of understand 'arp' as a single thing - but not the interface based ones ...

ken.
----------------------------------------
Bug #11196: EC2 facts do not get created when the arp table contains more than 
1 entry (patch included)
https://projects.puppetlabs.com/issues/11196

Author: Pieter Lexis
Status: Investigating
Priority: Normal
Assignee: 
Category: library
Target version: 
Keywords: ec2 arp
Branch: 
Affected Facter version: 1.6.3


We have an EC2 instance with a QEMU vm on it (don't ask, we cried as well when 
this was the only solution). This means that we have a bridge interface on the 
EC2 instance and that the arp table contains more than 1 entry (on EC2 the only 
entry is the gateway). The code in the arp module does not take this into 
account. Than the ec2 code infers that this isn't an ec2 instance (and doesn't 
create the ec2 facts), but it is. If you would be running a VPN service on EC2, 
this bug could hit you as well (as you have more than 1 interface).

This patch fixes that.

Pull request follows.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to