Issue #8273 has been updated by Matthaus Litteken.

Target version changed from 2.7.x to 2.7.3


----------------------------------------
Bug #8273: help face fails if it finds an option that does not have 
documentation
https://projects.puppetlabs.com/issues/8273

Author: Dan Bode
Status: Closed
Priority: Normal
Assignee: 
Category: Faces
Target version: 2.7.3
Affected Puppet version: 2.7.0
Keywords: 
Branch: https://github.com/bodepd/puppet/tree/issue%2Fmaster%2F8273


Although faces should provide sufficient documentation, there are times when 
they will not.

It appears that any face option without either a summary of description fails 
with the following error:

<pre>
puppet man node --trace
/opt/local/dev/puppet/lib/puppet/face/help/man.erb:76:in `man implementation, 
required on Ruby 1.8'
/opt/local/dev/puppet/lib/puppet/face/help/man.erb:72:in `each'
/opt/local/dev/puppet/lib/puppet/face/help/man.erb:72:in `man implementation, 
required on Ruby 1.8'
/opt/local/dev/puppet/lib/puppet/face/help/man.erb:51:in `each'
/opt/local/dev/puppet/lib/puppet/face/help/man.erb:51:in `man implementation, 
required on Ruby 1.8'
/opt/local/dev/puppet/lib/puppet/face/man.rb:54:in `man implementation, 
required on Ruby 1.8'
/opt/local/dev/puppet/lib/puppet/interface/action.rb+eval[wrapper]:204:in 
`__send__'
/opt/local/dev/puppet/lib/puppet/interface/action.rb+eval[wrapper]:204:in `man'
/opt/local/dev/puppet/lib/puppet/application/face_base.rb:234:in `send'
/opt/local/dev/puppet/lib/puppet/application/face_base.rb:234:in `main'
/opt/local/dev/puppet/lib/puppet/application.rb:315:in `run_command'
/opt/local/dev/puppet/lib/puppet/application.rb:307:in `run'
/opt/local/dev/puppet/lib/puppet/application.rb:411:in `hook'
/opt/local/dev/puppet/lib/puppet/application.rb:307:in `run'
/opt/local/dev/puppet/lib/puppet/application.rb:402:in `exit_on_fail'
/opt/local/dev/puppet/lib/puppet/application.rb:307:in `run'
/opt/local/dev/puppet/lib/puppet/util/command_line.rb:69:in `execute'
/opt/local/dev/puppet/bin/puppet:4
err: private method `gsub' called for nil:NilClass
err: Try 'puppet help man man' for usage
</pre>

I have tracked it down to the following code from around line 73 of 
lib/puppet/face/help/man.erb

<pre>
 72 <%     unique_options.sort.each do |name|
 73          option = action.get_option name
 74          text = option.description || option.summary -%>
 75   <%= '<' + option.optparse.join("> | <") + '>' %> -
 76 <%= text.gsub(/^/, '  ') %>
 77 <%     end -%>
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to