Issue #9708 has been updated by Ken Barber. Status changed from Merged - Pending Release to Re-opened Target version changed from 1.7.0 to 1.6.x
I'm reopening this because I want us to reconsider the target version. I'm proposed we cherry-pick this patch back to the 1.6.x branch: <https://github.com/puppetlabs/facter/pull/121> The reasons are: * Continued maintenance in 1.6.x makes it harder for people trying to add new OS. Since most effort like this does occur in 1.6.x, this patch is better placed here. * It actually does fix issues already - like hardwareisa and macaddress since the confines are removed, and we fall back to the 'exec' style confine * Perhaps the risk we first saw in Michael's first patch wasn't reconsidered when his second amended patch came out. The current patch is actually less risky the more I think about it. We hit an issue with #9599 that exasperated the need for this in 1.6.x ... and we will continue to hit it without this patch more or less. The alternative is to go back and modify 6 or so facts every time we want to add OS coverage which increases the change of making mistakes. ---------------------------------------- Refactor #9708: Remove redundancy from operatingsystem confines https://projects.puppetlabs.com/issues/9708 Author: Adrien Thebo Status: Re-opened Priority: Normal Assignee: Michael Kincaid Category: library Target version: 1.6.x Keywords: Branch: Affected Facter version: There are instances inside facter that that look like this <pre> confine :operatingsystem => %w{Solaris Linux Fedora RedHat CentOS Scientific SuSE SLES Debian Ubuntu Gentoo FreeBSD OpenBSD NetBSD OEL OVS GNU/kFreeBSD} </pre> Which should be written more cleanly as <pre> confine :kernel => %w{SunOS Linux FreeBSD OpenBSD NetBSD GNU/kFreeBSD} </pre> </pre> -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
