Issue #9418 has been updated by Josh Cooper. Status changed from In Topic Branch Pending Review to Code Insufficient
Hi Max, Thank you for your pull request. I ran into a few issues that need to be resolved before we can merge it. * I broke your commit into two, to separate white space changes from the other changes. I've pushed these changes to <https://github.com/joshcooper/puppet/tree/ticket/master/9418-update-naggen> It would be great if you can keep these separate to make reviewing the code that much easier. * Did you mean to base your fix on master? If you wanted this fixed in 2.7.x, it would need to be based off of that branch * I'm a little unsure how to actually deploy this application. What I tried was to copy ext/nagios/naggen to lib/puppet/application/naggen.rb (note I had to add an extension). If this is the desired approach, it might be useful to do a `git mv naggen naggen.rb` * After merging these changes into master, I get the folllowing error, as puppet/network/client has since been removed: <pre> $ puppet naggen /Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `gem_original_require': no such file to load -- puppet/network/client (LoadError) from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `require' from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.7/lib/active_support/dependencies.rb:239:in `require' from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.7/lib/active_support/dependencies.rb:225:in `load_dependency' from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.7/lib/active_support/dependencies.rb:596:in `new_constants_in' from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.7/lib/active_support/dependencies.rb:225:in `load_dependency' from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.7/lib/active_support/dependencies.rb:239:in `require' from /Users/josh/work/puppet/lib/puppet/application/naggen.rb:8 from /Users/josh/work/puppet/lib/puppet/util/command_line.rb:54:in `require' from /Users/josh/work/puppet/lib/puppet/util/command_line.rb:54:in `require_application' from /Users/josh/work/puppet/lib/puppet/util/command_line.rb:59:in `execute' from /Users/josh/work/puppet/bin/puppet:4 </pre> ---------------------------------------- Bug #9418: naggen doesn't use [naggen] section in puppet.conf anymore https://projects.puppetlabs.com/issues/9418 Author: Max Stepanov Status: Code Insufficient Priority: Normal Assignee: Max Stepanov Category: nagios Target version: Affected Puppet version: 2.7.1 Keywords: Branch: https://github.com/puppetlabs/puppet/pull/106 Since changes in puppet with run_mode naggen doesn't honor its puppet.conf section([naggen]). Attached is a fixed version using Puppet::Application class. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
