Issue #11595 has been updated by Josh Cooper.

Category set to deprecation
Status changed from Accepted to Merged - Pending Release
Assignee set to Matt Robinson
Target version set to Telly

This change was merged into master in 
<https://github.com/puppetlabs/puppet/commit/26093a8f8de214a2db982e1c70a987eb67496652>
----------------------------------------
Bug #11595: Find out if lib/puppet/indirector/catalog/active_record.rb find 
method can be deleted
https://projects.puppetlabs.com/issues/11595

Author: Matt Robinson
Status: Merged - Pending Release
Priority: Normal
Assignee: Matt Robinson
Category: deprecation
Target version: Telly
Affected Puppet version: 
Keywords: 
Branch: 


While deleting TransObject and TransBuckets in #11552 it was noticed that 
lib/puppet/indirector/catalog/active_record.rb:17 called 
resource.to_transportable.  to_transportable isn't defined anywhere, and 
actually wasn't defined at the time the call to it was added in commit 
a1371465.  There are tests around the code, but the tests use mocked objects so 
they don't appear to actually test anything.

It looks like the find method in lib/puppet/indirector/catalog/active_record.rb 
can be deleted and that the code in it was never used since it never worked.  
The save method has had some activity since it was introduced and is used for 
storeconfigs.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to