Issue #3757 has been updated by Jacob Helwig.
Status changed from In Topic Branch Pending Review to Merged - Pending Release
Target version set to 2.7.10
This has been merged into 2.7.x in
commit:86a806f595f8b7bb280c8c445eef51dfd71bf39d
(#3757) - Move enable/disable to its own lock
This change also contains a refactor split of Pidlock into its
anonymous counterpart.
Signed-off-by: Brice Figureau <[email protected]>
----------------------------------------
Feature #3757: --enable and --disable should be improved
https://projects.puppetlabs.com/issues/3757
Author: R.I. Pienaar
Status: Merged - Pending Release
Priority: Normal
Assignee:
Category: executables
Target version: 2.7.10
Affected Puppet version: 0.25.4
Keywords: mcollective enabledisable
Branch: https://github.com/puppetlabs/puppet/pull/216
At present the --enable/--disable and associated checks on the puppetd is all
done via a lock file /var/lib/puppet/state/puppetdlock.
My investigations reveal the behavior of this file to be:
* if exist and it's empty, someone ran --disable
* if exist and it's got a PID in it puppetd is doing a manifest run at present
* if it's absent its enabled and not running
The problem comes when you want to disable the daemon while it's running a
manifest. The lock file with PID in it will remain in place and once puppetd
is done doing its run it will remove the lock file, leaving your client enabled
when infact it was asked to disable the client and not run in future.
So I want to be able to disable future runs even while a current run is
happening. The easiest might be to have 2 lock files - one to indicate
enabled/disabled and one to indicate running dont start another concurrent run.
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en.
