Issue #11499 has been updated by Daniel Pittman. Status changed from Unreviewed to Accepted Assignee set to Daniel Pittman
Turns out our validation is woefully wrong against a whole bunch of valid addresses. Who would have thought that IPv6 and IPv4 validation are hard when you use a single regular expression? ---------------------------------------- Bug #11499: validation code for puppet resource host does not properly check if ip is valid https://projects.puppetlabs.com/issues/11499 Author: Garrett Honeycutt Status: Accepted Priority: Normal Assignee: Daniel Pittman Category: ralsh Target version: Affected Puppet version: 2.7.6 Keywords: Branch: It appears that we only check that the digits are [0-9] and period, while we should be doing an actual IP check Attempting to use a letter. Fails as expected. <pre> [root@puppet ~]# puppet resource host junk.tld ip=1.2.3.a ensure=present Could not run: Parameter ip failed: Invalid IP address </pre> Attempting to use a bad IP, which works and should not. <pre> [root@puppet ~]# puppet resource host junk.tld ip=10.10.10.10.10 ensure=present notice: /Host[junk.tld]/ensure: created host { 'junk.tld': ensure => 'present', ip => '10.10.10.10.10', target => '/etc/hosts', } </pre> -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
