Issue #8341 has been updated by Matt Robinson.

Status changed from Merged - Pending Release to Needs More Information

>From what I can tell the patch you just merged doesn't actually fix the 
>problem described.  I just replicated the multiple loading of the facts with a 
>similar setup to what Jeff described.  The problem isn't duplication in the 
>module or fact paths.  I tried this with just one directory in the modulepath 
>(where I put the stdlib module) and STILL get multiple loads of the same path.

    % puppet agent --test --modulepath=/tmp/facts1
    The interpreter parameter to 'setcode' is deprecated and will be removed in 
a future version.
    info: Loading facts in facter_dot_d
    info: Loading facts in root_home
    info: Loading facts in facter_dot_d
    info: Loading facts in root_home
    Could not retrieve root_home: private method `split' called for nil:NilClass
    Could not retrieve root_home: private method `split' called for nil:NilClass
    info: Caching catalog for facts
    info: Applying configuration version '1326239227'
    notice: Finished catalog run in 0.02 seconds

If I have stdlib in multiple directories in my modulepath I get two loads per 
dir in the path.

I looked into this because the code that was merged didn't include any tests, 
and it wasn't clear how it solved the problem.  It obviously doesn't.
----------------------------------------
Bug #8341: Loading facts repeatedly
https://projects.puppetlabs.com/issues/8341

Author: Trevor Vaughan
Status: Needs More Information
Priority: Normal
Assignee: Daniel Pittman
Category: facter
Target version: 2.7.10
Affected Puppet version: 
Keywords: custom fact, repeated
Branch: 
https://github.com/adrienthebo/puppet/tree/ticket/2.7.x/8341-prevent_duplicate_loading_of_facts


Puppet seems to be getting overzealous when loading custom facts.

Example:

<pre>
Loading facts in custom_fact_1
Loading facts in custom_fact_2
Loading facts in custom_fact_3
Loading facts in custom_fact_5
Loading facts in custom_fact_7
Loading facts in custom_fact_8
Loading facts in custom_fact_9
Loading facts in custom_fact_10
Loading facts in custom_fact_11
Loading facts in custom_fact_12
Loading facts in custom_fact_13
Loading facts in custom_fact_14
Loading facts in custom_fact_5
Loading facts in custom_fact_7
Loading facts in custom_fact_2
Loading facts in custom_fact_3
Loading facts in custom_fact_12
Loading facts in custom_fact_11
Loading facts in custom_fact_10
Loading facts in custom_fact_8
Loading facts in custom_fact_13
Loading facts in custom_fact_6
Loading facts in custom_fact_14
Loading facts in custom_fact_9
Loading facts in custom_fact_1
Loading facts in custom_fact_1
Loading facts in custom_fact_2
Loading facts in custom_fact_3
Loading facts in custom_fact_5
Loading facts in custom_fact_6
Loading facts in custom_fact_7
Loading facts in custom_fact_8
Loading facts in custom_fact_9
Loading facts in custom_fact_10
Loading facts in custom_fact_11
Loading facts in custom_fact_12
Loading facts in custom_fact_13
Loading facts in custom_fact_14
Loading facts in custom_fact_5
Loading facts in custom_fact_7
Loading facts in custom_fact_2
Loading facts in custom_fact_3
Loading facts in custom_fact_12
Loading facts in custom_fact_11
Loading facts in custom_fact_10
Loading facts in custom_fact_8
Loading facts in custom_fact_13
Loading facts in custom_fact_6
Loading facts in custom_fact_14
Loading facts in custom_fact_9
Loading facts in custom_fact_1
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to