Issue #10268 has been updated by Daniel Pittman. Status changed from Accepted to Code Insufficient
Hey. I reviewed both sets of code here, and none of them are acceptable. Specifically, both of them assume that there is *A* default route, which is flat-out untrue. Unless I see code and, especially, *tests* that handle other common network situations I am going to reject these as very, very misleading and troublesome in the real world: * a machine that has no default route at all * a machine with multiple default routes, same priority * a machine with multiple default routes, different priority * a machine with no /0 route, but two /1 routes, same priority, same router If the submitted code does anything about network interfaces, I also expect to see the permutations of network interfaces (eg: all routes on one interface, all routes on different interfaces) thoroughly tested as well. The pull request also misleadingly assumes that the default route is the "real" IP of a machine, which may be part of a heuristic to help take a guess at that, but calling it anything but a guess is also pretty undesirable. ---------------------------------------- Feature #10268: fact to determine gateway https://projects.puppetlabs.com/issues/10268 Author: Garrett Honeycutt Status: Code Insufficient Priority: Normal Assignee: Category: library Target version: 1.7.x Keywords: default route Branch: Affected Facter version: Feature request to have a fact that determines the gateway. Handy in templating /etc/sysconfig/network on a EL system among other things. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
