Issue #11663 has been updated by Daniel Pittman. Status changed from In Topic Branch Pending Review to Tests Insufficient
Mike, this is awesome. The one thing that we need to do before we can merge it is get some tests added. Would you be willing to tackle that - we really don't want to accidentally break this in future without knowing. If you can't, let us know and we can write them ourselves, but that will delay getting the code merged. :) ---------------------------------------- Feature #11663: Add FreeBSD support to blockdevice fact(s) https://projects.puppetlabs.com/issues/11663 Author: Mike Carlson Status: Tests Insufficient Priority: Normal Assignee: Mike Carlson Category: library Target version: Keywords: Branch: https://github.com/puppetlabs/facter/pull/137 Affected Facter version: I've added to the blockdevice.rb lib in master to support FreeBSD. You can see the code on a fork I made of facter on [github](https://github.com/m87carlson/facter/commit/f5f93ad28383f6a245ee89a8accd07b842bd1717) Here is an example on a FreeBSD Xen guest: <pre> blockdevices => ad0,da0,da1 blockdevice_ad0_model => QEMU HARDDISK/0.10.2 blockdevice_ad0_size => 4194304000 blockdevice_da0_model => QEMU QEMU HARDDISK 0.10 blockdevice_da0_size => 42991616000 blockdevice_da1_model => QEMU QEMU HARDDISK 0.10 blockdevice_da1_size => 10695475200 </pre> And here is a physical system with a combination of USB drives: <pre> blockdevices => ad10,ad12,ad4,ad6,ad8,da0,da1 blockdevice_ad10_model => WDC WD1003FBYX-01Y7B0/01.01V01 blockdevice_ad10_size => 1000204886016 blockdevice_ad12_model => WDC WD1003FBYX-01Y7B0/01.01V01 blockdevice_ad12_size => 1000204886016 blockdevice_ad4_model => ST2000DL003-9VT166/CC98 blockdevice_ad4_size => 2000398934016 blockdevice_ad6_model => WDC WD1003FBYX-01Y7B0/01.01V01 blockdevice_ad6_size => 1000204886016 blockdevice_ad8_model => WDC WD1003FBYX-01Y7B0/01.01V01 blockdevice_ad8_size => 1000204886016 blockdevice_da0_model => WD Ext HDD 1021 2021 blockdevice_da0_size => 3000590401536 blockdevice_da1_model => Initio INIC-1610P 1.01 blockdevice_da1_size => 2000398934016 </pre> size is reported in bytes. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
