Issue #11958 has been updated by Kelsey Hightower.

Status changed from Tests Insufficient to In Topic Branch Pending Review

Ok, I have updated my branch and all tests should be passing now:

    $ rspec spec/integration/provider/package_spec.rb
    ........*.
    Pending:
    Package provider gem should fail when asked to install an invalid package
    # This test hangs forever with recent versions of RubyGems
    # ./spec/integration/provider/package_spec.rb:11
    Finished in 0.77979 seconds
    10 examples, 0 failures, 1 pending
   
    [kelseyhightower@~/Workspace/puppet]$ rspec 
spec/unit/provider/package/pip_spec.rb 
    ...................
    Finished in 0.53722 seconds
    19 examples, 0 failures

Also, I have updated the error message to look like this:

    err: /Stage[main]/Dummy/Package[virtualenv]/ensure: change from absent to 
present failed: Could not set 'present on ensure: Could not locate the pip 
command. at /etc/puppet/modules/dummy/manifests/init.pp:5

I am thinking "Could not locate the pip command" would be a bit more helpful.
----------------------------------------
Bug #11958: obscure error message from pip package provider when python-pip is 
not installed
https://projects.puppetlabs.com/issues/11958

Author: Ahmed El Gamil
Status: In Topic Branch Pending Review
Priority: Normal
Assignee: Kelsey Hightower
Category: provider
Target version: 2.7.x
Affected Puppet version: 2.7.6
Keywords: error usability ux
Branch: https://github.com/puppetlabs/puppet/pull/337


Hi,

Puppet generates an obscure error when the pip command is not installed or not 
in PATH.

Error is like : 
[default] err: /Stage[main]/Uwsgi/Package[uwsgi]/ensure: change from absent to 
latest failed: Could not update: undefined method `pip' for 
#<Puppet::Type::Package::ProviderPip:0xb72b8998> at 
/tmp/vagrant-puppet/manifests/nodes-vagrant.pp:17

A more informative error message should be displayed, or even stopping the 
puppet run.

Thanks


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to