Issue #11996 has been updated by Daniel Pittman. Status changed from Accepted to In Topic Branch Pending Review
https://github.com/puppetlabs/puppet/pull/344 https://github.com/puppetlabs/puppet/pull/342 Those cover the 2.6 and 2.7 branches, neither of which we want to have with broken tests post-CVE update. Done as two pulls because the merge was non-trivial, and there were substantial extra changes for 2.7 to work. master is identical to 2.7, and merges cleanly. ---------------------------------------- Refactor #11996: Spec test failures in 1.8.7p357 due to hash ordering changes... https://projects.puppetlabs.com/issues/11996 Author: Daniel Pittman Status: In Topic Branch Pending Review Priority: Normal Assignee: Category: Doh! Target version: Affected Puppet version: 2.7.0 Keywords: Branch: Now the hash order changes when Ruby is run, some tests are failing because they look to be dependent on the order in which the hash is processed. Typically is this: <pre> 1) Puppet::Parser::AST::ASTHash should return a valid string with to_s Failure/Error: hash.to_s.should == '{a => b, c => d}' expected: "{a => b, c => d}" got: "{c => d, a => b}" (using ==) # ./spec/unit/parser/ast/asthash_spec.rb:95 2) Puppet::Property::KeyValue as an instance should return the passed in array values joined with the delimiter from is_to_s Failure/Error: @property.is_to_s({"foo" => "baz" , "bar" => "boo"}).should == "foo=baz;bar=boo" expected: "foo=baz;bar=boo" got: "bar=boo;foo=baz" (using ==) # ./spec/unit/property/keyvalue_spec.rb:39 </pre> Note the output reverses the previous order, and is still likely correct, just disordered? Also, kind of random because the hash seed is random, I believe, in this patch. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
