Issue #10232 has been updated by eric sorenson. Assignee set to Mikael Fridh
Triage-A-Thon: Mikael, this is your branch - please add some tests - there is a pretty comprehensive wiki page on the coding standards for tests here: http://projects.puppetlabs.com/projects/1/wiki/Development_Writing_Tests ---------------------------------------- Feature #10232: virtual: Get virtual information from sysfs (no dmidecode and lspci on virtualbox) https://projects.puppetlabs.com/issues/10232 Author: Mikael Fridh Status: Tests Insufficient Priority: Normal Assignee: Mikael Fridh Category: library Target version: 1.6.x Keywords: virtualbox Branch: https://github.com/frimik/facter/tree/virtualbox Affected Facter version: 1.6.2 https://github.com/puppetlabs/facter/pull/83#issuecomment-2485524 " I found that the virtual fact said "physical" on my virtualbox machine because I had a minimal install. This fix reads from /sys/devices/virtual/dmi/id/product_name and gets the value VirtualBox. I'm sure it works on several other hypervisors but virtualbox is all I have to test on so I'm leaving it at that. " I know this is a narrow use case at this point, but it fixed my issue - getting the fact right even on a minimally installed VM. This could probably be extended to get more information on kernel 2.6 linux. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
