Issue #8917 has been updated by Daniel Pittman.

Status changed from In Topic Branch Pending Review to Code Insufficient

I think this needs more work to eliminate the lingering remains of the 
`--client` option from `lib/puppet/application/agent.rb`, and delegate only to 
the settings.

I think the option declaration in the agent should go, and we should also be 
able to eliminate the local `options[:agent]` code entirely in favour of the 
global setting.  

...or I need to have explained how I am wrong about that. :)

I didn't actually check if the feature is covered by existing tests, either, so 
we might need to attend to that...
----------------------------------------
Bug #8917: `client` is not a configuration option, and --client/--no-client is 
handled by the agent application
https://projects.puppetlabs.com/issues/8917

Author: Nick Fagerlund
Status: Code Insufficient
Priority: Normal
Assignee: 
Category: agent
Target version: Telly
Affected Puppet version: 
Keywords: 
Branch: https://github.com/puppetlabs/puppet/pull/379


Okay, puppet agent has a `--no-client` option that makes it sit around and wait 
for commands over REST instead of proactively fetching a configuration. But 
unlike all the other `--something/--no-something` pairs, it's not a config 
option from defaults.rb -- it only exists in the agent application. That means 
there's no way to persistently set this behavior in puppet.conf, as the 
commenters to #4411 found out. 

Should there be? If you're using this feature at all, you're using it all the 
time, which makes it seem like a prime candidate for the config file. 


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to