Issue #11955 has been updated by Jeff McCune. Branch changed from https://github.com/puppetlabs/puppet/pull/363 to https://github.com/puppetlabs/puppet/pull/392
# Updated PR # I rebased Josh's pull request and submitted a new PR replacing the old PR. <https://github.com/puppetlabs/puppet/pull/392> The code is a +1 from me but leaving to Daniel for final review since we're monkey patching foundational system calls. ---------------------------------------- Refactor #11955: Refactor uses of Puppet::Util.binread https://projects.puppetlabs.com/issues/11955 Author: Josh Cooper Status: In Topic Branch Pending Review Priority: Normal Assignee: Josh Cooper Category: windows Target version: 2.7.x Affected Puppet version: 2.7.6 Keywords: Branch: https://github.com/puppetlabs/puppet/pull/392 This method is available in IO.binread in ruby 1.9 and above. We should monkey patch when running on earlier versions, and also add IO.binwrite while we're at it. Also, places that call File.read/File.write should be changed to use binread/binwrite, unless we know we're dealing with a text file that may require '\r\n' line endings on Windows -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
