Issue #12188 has been updated by Brice Figureau.
Brice Figureau wrote: > Alexander Swen wrote: > > also see #12183 > > Yes, this is a dup. Alexander confirmed that my above patch worked for him. > > Also, this was introduced in: > https://github.com/masterzen/puppet/commit/b434e3b9c31de63365e1a0f53d152be7e6e988ec > > I really fail to see how the problem was introduced... > > Note: I don't really think it's an urgent issue. This is just an harmless > error message, it doesn't break anything. In fact this was introduced in e0e31d571f38a3f0436e43ea6662f6d6c1e525c5 (from #5246). This patch added a daemon.stop call for no-daemonize which in turn tries to remove the pid and since it can't (since it's not ours), it errors. The fix I proposed is I believe the correct one. ---------------------------------------- Bug #12188: agent when run --no-daemonize tries to remove the pid of a running daemon https://projects.puppetlabs.com/issues/12188 Author: R.I. Pienaar Status: Accepted Priority: Urgent Assignee: Daniel Pittman Category: plumbing Target version: Affected Puppet version: Keywords: Branch: The fix in #5246 got the agent remove its pid after running. It's unfortunately too big a hammer as when the agent is also running daemonized the pid removal will fail and log an err level message. Before removing the pid file we should figure out if the pid file belongs to the current process and only then remove it. This is confirmed on 2.7.10 but might also be the case in 2.6 master -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
