Issue #5698 has been updated by Daniel Pittman.

Description updated
Status changed from Unreviewed to Closed


----------------------------------------
Bug #5698: Use of :absent and nil is inconsistent in inspect reports
https://projects.puppetlabs.com/issues/5698

Author: Paul Berry
Status: Closed
Priority: Normal
Assignee: 
Category: 
Target version: 
Affected Puppet version: 2.6.0
Keywords: 
Branch: 


This only affects reports generated by the new experimental "inspect" feature.

If you inspect a file /tmp/foo which is present, you see something like this:
owner: <user id>
type: :file
target: nil
mode: 644
ensure: :file

If you inspect a file which is absent, all properties show the value :absent.
type: :absent
target: :absent
mode: :absent
ensure: :absent

This really doesn't make sense.  In the case of the "ensure" property, we are 
using :absent to mean "file is not there", but in the other properties, it 
really means "N/A".  However, we use "nil" to represent "N/A" in other 
circumstances (e.g. "target" is nil for regular files).

This can lead to counter-intuitive diff reports.  For example, if a file is 
deleted, then it will show up in the inspect report as having its target 
changed from nil to :absent.  Really it would be better if we used nil 
consistently to represent N/A so that the "target" parameter wouldn't even show 
up in this diff.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to