Issue #9670 has been updated by Daniel Pittman. Status changed from In Topic Branch Pending Review to Code Insufficient Branch deleted (https://github.com/puppetlabs/puppet/pull/274)
Sorry for the long delay getting to reviewing this. That change actually breaks another test, around the node environment, and seems like it is not really the right solution. We will try and dig into what should be happening, and work out how to fix things, but for now we can't just merge this. ---------------------------------------- Bug #9670: puppet parser validate --ignoreimport ignores a bit too much https://projects.puppetlabs.com/issues/9670 Author: Anchor Systems Status: Code Insufficient Priority: Normal Assignee: Category: parser Target version: Affected Puppet version: 2.7.3 Keywords: Branch: Attempting to validate changed manifests in a git pre-commit hook, I found that a regular `puppet parser validate` was complaining about not being able to find imported files. So, I whacked `--ignoreimport` in there and all seemed fine... until I realised it wasn't finding legitimate syntax errors. Turns out that `--ignoreimport` ignores a bit too much, and doesn't actually perform a parse. Quick fix was to remove the first line of `perform_initial_import` (in `node/environment.rb`) so that it didn't return immediately. What other effects that might have, I couldn't rightly say, but at least I know when I've broken my manifests now. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
