Issue #10625 has been updated by Daniel Pittman. Status changed from Tests Insufficient to Merged - Pending Release Target version changed from 1.6.x to 2.0.0
No problem at all - we don't expect people outside the office to be experts on day one. Thank you for having the patience to work through the process and get the tests all working and everything. Very much appreciated, and your code is now merged. Good job! ---------------------------------------- Bug #10625: Xen dom0 and domU hosts reported as physical without xenfs mounted https://projects.puppetlabs.com/issues/10625 Author: Grant Heffernan Status: Merged - Pending Release Priority: High Assignee: Category: library Target version: 2.0.0 Keywords: virtual Branch: https://github.com/puppetlabs/facter/pull/164 Affected Facter version: 1.6.2 Facter 1.6.2 is reporting all my Rackspace virtuals as reals, which breaks all kinds of things. Rolling back to 1.6.1 clears it up. root@prod-fe-r02:/etc/monit/conf.d# facter | grep virtual is_virtual => false virtual => physical root@prod-fe-r02:/etc/monit/conf.d# gem list *** LOCAL GEMS *** facter (1.6.2) puppet (2.7.6) rake (0.8.7 ruby) root@prod-fe-r02:/etc/monit/conf.d# gem uninstall facter You have requested to uninstall the gem: facter-1.6.2 puppet-2.7.6 depends on [facter (>= 1.5.1)] If you remove this gems, one or more dependencies will not be met. Continue with Uninstall? [Yn] y Remove executables: facter in addition to the gem? [Yn] y Removing facter Successfully uninstalled facter-1.6.2 root@prod-fe-r02:/etc/monit/conf.d# gem install facter -v=1.6.1 --no-ri --no-rdoc Fetching: facter-1.6.1.gem (100%) Successfully installed facter-1.6.1 1 gem installed root@prod-fe-r02:/etc/monit/conf.d# facter | grep virtual is_virtual => true virtual => xenu -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
