Issue #11988 has been updated by Dominic Cleal. Assignee deleted (Dominic Cleal)
If refactoring the provider back to the pre-2728 style, it's worth bearing in mind the performance impact was due to Augeas being opened as NOOP during the retrieve, changes are run, the handle's closed, opened as OVERWRITE during sync, changes run and handle closed again. Each time Augeas starts up, it re-parses the files it knows, which takes seconds. If the the handle was kept open between retrieve and sync (assuming it's not noop, and changes need to be made), then the sync method could be as simple as changing the save mode to BACKUP and calling save again to write to disk. ---------------------------------------- Bug #11988: Augeas provider can clobber symlinks https://projects.puppetlabs.com/issues/11988 Author: Nathan Huff Status: Accepted Priority: Normal Assignee: Category: augeas Target version: 2.7.x Affected Puppet version: 2.7.9 Keywords: augeas Branch: If the augeas resource is fed a symlink as the target file and it makes changes it will overwrite it with a regular file. It creates and .augnew file and just blindly moves it into place without checking if the target file was a symlink. The provider should either check whether the target was a symlink and dereference it or it should rerun augeas in overwrite mode since augeas does take care to dereference if necessary. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
