Issue #2847 has been updated by Ken Barber.
Okay - I think doing a mount point fact before structured data is implemented is going to be sub-par - at least having it in core. We really want to represent all fs types, however having this is going to look terrible in mount_devices and traversing the data in a flattened form is less-then-useful. The data really needs a hash I think, if we want to represent it properly and we just don't do that now. For this reason I'm going to shelve the current suggested branch/pull request until we get structured facts implemented. Sorry - feel free to convince me otherwise. I'll put a dependency on #4561 to reflect this. We are hopefully planning to implement #4561 for Telly (2.8) now anyway, so hopefully we won't have long to wait. Users who want to use KW's implementation can find it here: <https://github.com/kwilczynski/facter-facts/blob/master/mounts.rb> ---------------------------------------- Feature #2847: mountpoint fact https://projects.puppetlabs.com/issues/2847 Author: anarcat - Status: In Topic Branch Pending Review Priority: Normal Assignee: Michael Kincaid Category: library Target version: 1.7.x Keywords: mounts, devices Branch: Affected Facter version: I have implemented, based on work by the Debian's Sysadmin team, a fact that allows listing of the mountpoints (and associated devices). I have attached the code for the fact, which is called "mountpoints" but also exports "devices". I have requested and got approval from the original author (Stephen Gran, which code can still be seen here: http://git.debian.org/?p=mirror/dsa-puppet.git;a=blob;f=facts/mounts.rb;hb=HEAD) before contacting you. To quote him: "git blame indicates that all the current code in the mounts fact is mine, so I'm happy to license it under the GPL (of any verson, as that is apparently the puppet license, at first glance) for purposes of pushing it upstream. OTOH, it is about 20 lines of fairly trivial code, so I'm not sure copyright is even an issue." Apparently, his original code was relying on the presence of the "Filesystem" Ruby library, which may not be desirable in this case, which is why I implemented a linux workaround. It's my first fact ever, so I'm very curious to see if I have done this properly or if there are possible improvements to the code. I know comments could be good... My working copy of the code is also available through git: http://git.koumbit.net/?p=puppet/modules/common.git;a=blob;f=plugins/facter/mountpoints.rb;hb=HEAD Thanks, A. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
