Issue #12490 has been updated by Josh Cooper. Category set to testing Status changed from In Topic Branch Pending Review to Merged - Pending Release Target version set to Telly Affected Puppet version set to development
I merged this into master in <https://github.com/puppetlabs/puppet/commit/194b2c3>. If you want to spend more time to address Daniel's concerns, that'd be great too. ---------------------------------------- Bug #12490: execution_spec is stomping on process ENV variables https://projects.puppetlabs.com/issues/12490 Author: Chris Price Status: Merged - Pending Release Priority: Urgent Assignee: Chris Price Category: testing Target version: Telly Affected Puppet version: development Keywords: Branch: https://github.com/puppetlabs/puppet/pull/472 The execute_posix method: a) Should not be called during windows test runs, and b) Needs to take more care not to inadvertently set environment variables in the main ruby process. When the test was written, I assumed that the latter would not be a problem because the environment variable manipulation was only supposed to happen in a forked process; however, because these tests stub the Kernel.fork method, the process is never actually forked and thus the environment variable manipulation happens in the parent process. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
