Issue #12359 has been updated by Daniel Pittman.

Status changed from In Topic Branch Pending Review to Merged - Pending Release


----------------------------------------
Refactor #12359: improve logging of backtraces
https://projects.puppetlabs.com/issues/12359

Author: Chris Price
Status: Merged - Pending Release
Priority: Low
Assignee: Chris Price
Category: 
Target version: Telly
Affected Puppet version: 
Keywords: 
Branch: https://github.com/puppetlabs/puppet/pull/456


Add a utility method to Puppet::Util::Logging (or similar) that can be used for 
logging exceptions.  Currently, there are a ton of places in the code where we 
do this:

    rescue = > detail
       puts(exception.backtrace) if Puppet[:trace]

This has a few problems:

1. It's not very DRY
2. The "puts" approach means that we always try to write the traces to stdout.  
When running via puppet master in daemon mode, this often results in the 
messages just getting thrown away.

Debugging the Puppet Master and Agent daemons would be made much easier in 
certain cases if the traces were logged via the normal puppet logging framework 
rather than via puts.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to