Issue #12435 has been updated by Daniel Pittman.
Other questions from the code: The tests you have are good, but they don't cover the behaviour of the external script: * what happens when the external script fails? * what happens when the external script is sleep 900? * what happens when the external script prints to STDOUT, and to STDERR? You also don't test all the current permutations of invocation - I don't see testing of failonfail true and false differences in behaviour there. (I think that feature should go, but if it stays, it should be tested.) I don't see tests that the places invoking the alert do the right thing - the public API needs more testing. Otherwise, with some polish and a bit more thought about how it interacts with the logging subsystem, seems like a reasonable thing to me. We should probably run this around UX a bit and see what they think. ---------------------------------------- Feature #12435: Adding alerting support to command line actions https://projects.puppetlabs.com/issues/12435 Author: James Turnbull Status: Needs Decision Priority: Normal Assignee: Randall Hansen Category: Faces Target version: Telly Affected Puppet version: Keywords: Branch: https://github.com/jamtur01/puppet/tree/alerting Many Puppet command line functions, for example installing, managing or uninstalling a Puppet module are collaborative actions. You often want to share news of these actions with others. The alerting framework allows you to specify an option, for example `--alert` to a Face (see the puppet module install and uninstall faces in the attached branch) for this) that executes a script that can alert others to the action, for example send an IRC or Campfire notification when a module is installed or uninstalled. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
