Issue #12396 has been updated by Daniel Pittman. Status changed from In Topic Branch Pending Review to Tests Insufficient
Comments in the pull request; this needs testing for the new module specifically, and a better name than just `timeout` for the method. Otherwise I am happy to take this change. ---------------------------------------- Refactor #12396: DRY up self.timeout https://projects.puppetlabs.com/issues/12396 Author: Jeff Weiss Status: Tests Insufficient Priority: Low Assignee: Jeff Weiss Category: Target version: Telly Affected Puppet version: Keywords: Branch: https://github.com/puppetlabs/puppet/pull/450 We have several duplicate definitions of self.timeout across several different files. * source:lib/puppet/configurer.rb#L201 * source:lib/puppet/configurer/downloader.rb#L8 * source:lib/puppet/indirector/facts/facter.rb#L59 This definition should be moved to a module and included in each of the above. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
