Issue #11612 has been updated by Ken Barber.
Hi Hu (I've been calling you Hongbo, but I presume your "given" name is Hu? - I do apoligise either way :-), So I've made some comments on your code here: <https://github.com/puppetlabs/facter/pull/127/files> There is a case where you are doing a model =~ /IBM/ which breaks, and I can't explain. Also - your removal of ia64 and hppa for the /proc/cpuinfo parser means the change will break Linux on these particular platforms. I'm guessing that HP-UX must have a /proc/cpuinfo that we don't parse correctly. Is it at all possible for you to attach the output of that file to this ticket for me so I can see it for myself? We perhaps should be limiting our parsing to Linux only if HP-UX also has this file ... but I'm not entirely sure of the consequences of such a decision yet. ---------------------------------------- Feature #11612: add facter support for ia 11.31 hpux processor discover and a bug fix for network interface https://projects.puppetlabs.com/issues/11612#change-54818 Author: hongbo hu Status: Tests Insufficient Priority: Normal Assignee: Category: library Target version: 1.6.x Keywords: facter hpux Branch: https://github.com/puppetlabs/facter/pull/127 Affected Facter version: 1.6.4 1. add cpu information support to facter support HPUX 11.31 IA64 2. when server has mc-sg the network card has standby lan card marked with '*' ,when run faster ,it'll show ifconfig no such interface error pull requre at github https://github.com/puppetlabs/facter/pull/127 I'll add more feature for hp and aix -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
