Issue #12720 has been updated by Ken Barber. Category set to library Status changed from In Topic Branch Pending Review to Tests Insufficient Assignee set to Chris Gardner Target version set to 1.6.x Keywords set to solaris, processorcount Branch set to https://github.com/chrisgardner/facter/tree/solaris_cpuinfo
So this looks good, but there are 4 test failures for me. I've made comments in your code as to the solutions. Also - make sure your using my_fixture_read instead of deriving your own, there are examples all over the facter code so you should be able to see how to use it. I know the example in the file doesn't use it - I guess thats something that needs to be fixed. I think we can also slide this into 1.6.x as well as this is considered a 'fix' for processor count. If you would like to rebase your code on that branch that would be awesome - but we'll need to re-open the pull request for this to work. Thanks! ---------------------------------------- Feature #12720: Add CPU info for Solaris to processorN fact https://projects.puppetlabs.com/issues/12720#change-55237 Author: Chris Gardner Status: Tests Insufficient Priority: Normal Assignee: Chris Gardner Category: library Target version: 1.6.x Keywords: solaris, processorcount Branch: https://github.com/chrisgardner/facter/tree/solaris_cpuinfo Affected Facter version: Add Solaris support for the 'processorN' fact to display CPU info. On Solaris, CPU info can be determined with the command `kstat cpu_info`: module: cpu_info instance: 0 name: cpu_info0 class: misc brand QEMU Virtual CPU version 0.15.1 cache_id 0 chip_id 0 clock_MHz 3000 clog_id 0 core_id 0 cpu_type i386 crtime 10958.349558039 current_clock_Hz 2999595231 current_cstate 0 family 6 fpu_type i387 compatible implementation x86 (GenuineIntel family 6 model 2 step 3 clock 3000 MHz) model 2 ncore_per_chip 1 ncpu_per_chip 1 pg_id -1 pkg_core_id 0 snaptime 22576.720819271 state on-line state_begin 1329682158 stepping 3 supported_frequencies_Hz 2999595231 supported_max_cstates 1 vendor_id GenuineIntel **brand** equates to **model name** from `/proc/cpuinfo` on Linux. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
