Issue #12269 has been updated by Deepak Giridharagopal.

Status changed from In Topic Branch Pending Review to Merged - Pending Release


----------------------------------------
Bug #12269: Puppet fails to sort `Puppet::Type` instances when more than one 
cycle exists in a graph.
https://projects.puppetlabs.com/issues/12269#change-55260

Author: Daniel Pittman
Status: Merged - Pending Release
Priority: Normal
Assignee: 
Category: Doh!
Target version: 2.7.x
Affected Puppet version: 2.7.10
Keywords: 
Branch: 


When #11996 was fixed, the change was restricted to sorting the cycles detected 
using proxy keys - `sort_by` - rather than adding sorting to the `Puppet::Type` 
class.  The sorting itself was needed to ensure consistent output of the cycles 
found.

Using a proxy key for sorting was less intrusive, but clearly not less risky, 
since several issues have cropped up from the change.

The specific failure is that when there is more than one cycle, each is 
internally sorted, then the entire set are sorted.  The later doesn't stringify 
the type instances correctly, so tried to compare two objects that can't be 
ordered...


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to