Issue #12371 has been updated by Nigel Kersten.
Daniel Pittman wrote: > Nigel Kersten wrote: > > Shouldn't we fix the autoloading rather than implementing a whitelist? > > Sorry, fix it how? Should we assume that something in `puppet/functions` was > intended to be in `puppet/parser/functions`? Spell-check filenames and see > if that makes it possible to autoload a file? Use the hamming distance > between the name of a file and the name of a file we could autoload to figure > out the user meant it to work, but got it wrong? I wasn't implying anything like that and it sounds like I've gotten the wrong impression about what the problem actually is in this ticket. If the problem is lack of visibility into module/lib directories where people have used the wrong paths, I'm not sure how: "we should not warn for foo or other top level namespaces we don’t own." is going to fix someone using "lib/features" rather than "lib/puppet/features". If the problem is people using: "lib/puppet/foo" rather than "lib/puppet/features/foo", it sounds like the proposal is that people won't be able to extend puppet with arbitrary directories under "puppet" and deliver those extensions with pluginsync without getting a warning right? I'm a little concerned about that aspect, of us maintaining a whitelist of sanctioned directories underneath "puppet". Do we have signal that people make mistakes in that direction? where they have "puppet" in the path, but get the rest wrong? ---------------------------------------- Bug #12371: pluginsync should warn when files are not in a special directory https://projects.puppetlabs.com/issues/12371#change-55305 Author: Patrick Carlisle Status: Accepted Priority: Normal Assignee: Patrick Carlisle Category: plug-ins Target version: Affected Puppet version: Keywords: Branch: If you put files in a module in a directory that doesn't get autoloaded there should be some sort of warning. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
