Issue #12685 has been updated by Chris Price.

Status changed from Unreviewed to Accepted


----------------------------------------
Bug #12685: CONTRIBUTING.md is ambiguous on a few points
https://projects.puppetlabs.com/issues/12685#change-55360

Author: Ken Barber
Status: Accepted
Priority: Normal
Assignee: 
Category: 
Target version: 
Keywords: 
Branch: 
Affected Facter version: 


>From Todd Zullinger:

    (I read CONTRIBUTING.md and didn't see it make as big a deal about creating 
tickets so I thought one might not be needed. Not a complaint, just noting 
    where I got the notion that a pull request might be good enough. ;)

    P.S. I was too busy (and lazy) to make another patch, but CONTRIBUTING.md 
also says "The current stable series is 2.7.x, and the current maintenance 
    series is 2.6.x." which is clearly borrowed from the puppet version of the 
doc. Not sure if anyone could manage to get confused by that, I would hope 
    most of us know puppet along with facter.

So a few points:

* The versioning is incorrect in facter's version of the file
* It doesn't explicitly state the conditions for when a Redmine ticket is 
required. It should talk about (maint) style changes, searching for existing 
tickets and finally if necessary creating a new ticket.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to