Issue #12381 has been updated by Pieter van de Bruggen. Status changed from Accepted to In Topic Branch Pending Review Keywords changed from geordi to geordi v1
This appears to have been consistently implemented. ---------------------------------------- Feature #12381: Need to consistently display forge_name for all module tool commands https://projects.puppetlabs.com/issues/12381#change-57586 Author: Matt Robinson Status: In Topic Branch Pending Review Priority: Normal Assignee: Pieter van de Bruggen Category: modules Target version: 2.7.x Affected Puppet version: Keywords: geordi v1 Branch: There's inevitably going to be some disconnect between the way Puppet deals with module names vs the way the forge deals with module names since for Puppet, a module's name is just it's directory, but for the forge the name is 'author/modname'. When doing `puppet module list` should we display the forge name by default, or just the module's directory name? Same kind of concern for upgrade and uninstall, should upgrade accept just the simple name and still work for modules that have metadata (ex `puppet module upgrade foo` will upgrade puppetlabs/foo or not)? # displaying and using forge name by default pros: * it's clearer that the module has metadata * the module name is more consistent with what you have to pass to `puppet module install` * for upgrade and uninstall it could make it clearer which module you intend to act on cons: * modules without metadata, which I imagine for most people will be most of their modules, will have a name format that's different than modules with metadata * the forge name won't match the directory name in which the module is installed * for upgrade and uninstall it raises the question of what to do if you just give the dir name for the action when the module has metadata My gut feeling right now is that having just install need to deal with the forge name is the better path right now, and leave the other commands showing the module's directory name. I think that inconsistency is less confusing than the inconsistency between the dir name being different from the forge name when you're interacting with list, upgrade and uninstall. I know Pieter feels the other way. I'm willing to be convinced. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
