Issue #13210 has been updated by Jeff McCune.

R.I. Pienaar wrote:
> I'm in favour of making undef behave like ruby nil in templates and 
> functions, might be a painful transition but ultimately it means any 
> beginners guide to Ruby actually applies to our code where right now almost 
> every sysadmin who comes to Ruby via puppet finds it a rather painful 
> experience.

+1

A criticism I often received when training people was that "Puppet is 
inconsistent". I believe how we cast things to strings in functions, 
particularly undef values, is a major contributor to this perception.

This is absolutely not something we should change in a minor release and 
ideally we'll have a full major release where we give a deprecation warning 
with clear steps to take for authors of functions and types.
----------------------------------------
Bug #13210: undef changes into '' when passed to function as a param
https://projects.puppetlabs.com/issues/13210#change-59042

Author: Timur Batyrshin
Status: Needs Decision
Priority: Normal
Assignee: Chris Price
Category: 
Target version: 
Affected Puppet version: 
Keywords: 
Branch: 


Suppose we have a manifest like that:
<pre>
define foo ( $x = '1' ) {
  notify { "x${x}": }
}

class bar {
  $x = myfunc( undef )
  foo {'no1': x=> $x }
}

class baz {
  $x = undef
  foo {'no2': x=> $x }
}


include bar
include baz
</pre>

With myfunc() defined like that:
<pre>
module Puppet::Parser::Functions
    newfunction(:myfunc, :type => :rvalue) do |param|
      return param
    end
end
</pre>

When applying the manifest we get the following output.
<pre>
notice: x
notice: /Stage[main]/Bar/Foo[no1]/Notify[x]/message: defined 'message' as 'x'
notice: x1
notice: /Stage[main]/Baz/Foo[no2]/Notify[x1]/message: defined 'message' as 'x1'
notice: Finished catalog run in 0.06 seconds
</pre>

However the same message should be produced in both calls to foo.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to