Issue #13682 has been updated by Daniel Pittman.

Hrm.  Feels to me like this is the wrong direction to approach this from.  The 
problem is that we have trouble if the gem is installed and RubyGems are 
active, right?

Much better that we push people to do the right thing, which is uninstall the 
gem now they have the real deal installed.

That can be checked by using the gem system to figure out if the problem code 
is installed; that requires:

<pre>
def gem_available?(name)
   Gem::Specification.find_by_name(name)
rescue Gem::LoadError
   false
rescue
   Gem.available?(name)
end
</pre>

...and then you can cleanly and politely fail instead.

----------------------------------------
Bug #13682: Puppet should not conflict with released puppet-module Gem
https://projects.puppetlabs.com/issues/13682#change-60945

Author: Jeff McCune
Status: In Topic Branch Pending Review
Priority: Normal
Assignee: 
Category: compatibility
Target version: 2.7.x
Affected Puppet version: 2.7.12
Keywords: constants ARTIFACTS puppet-module REPOSITORY_URL namespace
Branch: https://github.com/puppetlabs/puppet/pull/641


# Overview #

The current behavior of Puppet 2.7.x (2.7.12-99-g8ceaaf0) declares some 
constants which conflicts with the already released puppet-module gem.  Since 
the released gem requires Puppet, they fight with each other over these 
constants.

# Impact data #

All module authors are affected by this since they will need to do a knife-edge 
cut over from the existing module tool to Puppet 2.7.12, _or_ choose not to 
upgrade Puppet beyond 2.7.10.

# Steps to reproduce #

Use the existing puppet-module gem to build a package with Puppet 2.7.x.  These 
conflicts become evident:

<pre>
/vagrant/src/puppet/lib/puppet/module_tool.rb:14: warning: already initialized 
constant ARTIFACTS
/vagrant/src/puppet/lib/puppet/module_tool.rb:16: warning: already initialized 
constant REPOSITORY_URL
</pre>

I should be able to fix this quickly, so I'm assigning it to myself.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to