Issue #13341 has been updated by Patrick Carlisle. Branch set to https://github.com/pcarlisle/puppet/tree/ticket/master/13341-nested-exceptions
Working on this here https://github.com/pcarlisle/puppet/tree/ticket/master/13341-nested-exceptions not quite ready yet ---------------------------------------- Refactor #13341: Add support for nested exceptions in Puppet::Error https://projects.puppetlabs.com/issues/13341#change-61861 Author: Chris Price Status: Accepted Priority: High Assignee: Patrick Carlisle Category: Target version: Telly Affected Puppet version: Keywords: Branch: https://github.com/pcarlisle/puppet/tree/ticket/master/13341-nested-exceptions There are a decent number of places in the code where we catch an exception and then raise a Puppet::Error in response. This can be a useful pattern when we have any extra information to add to the exception, but it comes at a painfully high price if we aren't careful not to lose the backtrace information from the original exception. I would like to add an optional extra argument to the constructor for Puppet::Error that would allow you to pass in a nested exception, and then tweak the Logging#log_exception method to print the full series of backtraces when it is called with a Puppet::Error that takes advantage of this nesting. Daniel, can you let me know if you have any concerns about this proposal? If not I will probably tackle it relatively soon because I think it could be extremely helpful for debugging and troubleshooting. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
