Issue #7520 has been updated by Max Martin. Status changed from Accepted to Needs Decision Priority changed from Urgent to High
After working on this for a few days, I'm not convinced it's a problem—and if it is, I'm not convinced it's one we should fix. A puppet report is a report of what occurred during a Puppet run, and all of the information within the report is information about the run itself. Accordingly, the time stored on the report is the time at which puppet "ran"—at least, the time puppet thought it was when it ran. The time at which the master processed the report is not information about the puppet run itself, but rather is metadata about the report. Because of this, I do not think it is appropriate information to store in the report itself. Reports are actually already stamped with the time the master processed them, though, in the form of their filename (at least when they are processed by the default store report processor). I feel that this is the appropriate level to store this information. If we do decide to store the time at which the report was processed by the master in the report itself, we will need to do so as part of a new report format. This is a decision that I feel should be made by the platform team. Personally, I feel like re-timestamping reports will introduce inaccuracy (via network latency) more often than it introduces accuracy. I think munging reports to include their processed time might be appropriate to do in a custom report processor, or in Dashboard. For the moment, I think that the action taken by the default store report processor (stamp the reports with the time they were processed in their filename) is appropriate. ---------------------------------------- Bug #7520: timestamp on reports should be taken from server, not client https://projects.puppetlabs.com/issues/7520#change-62488 Author: Chris Phillips Status: Needs Decision Priority: High Assignee: Daniel Pittman Category: Target version: 3.X Affected Puppet version: 2.6.7 Keywords: Branch: The timestamp on a report is taken from the report data sent by the client. If, for example, a new machine is being built and the system clock has not been set and ntp is not yet running and synchronized then the report can easily have a date in the future, or significantly in the past. The time of a report should come from the time that the puppetmaster believes it receives it and should not be taken directly from the data sent back by the client. I originally noticed this inconsistency in Dashboard, but is surely an issue coming out of Puppet (unless Dashboard has multiple timestamps to use and is making a bad choice of which one it uses) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
