Issue #3909 has been updated by Daniel Pittman.
>From the pull request: > jeffmccune commented 19 hours ago > If we strip trailing dots from the domain fact we no longer support fully > qualified domains. I don't think we want to force everyone to an unqualified > domain. As discussed in the ticket, this was rarely possible in any case. Now, rather than having undefined behaviour where some rare set of failures could potentially lead to a fully qualified search path in resolv.conf leading to this fact having a trailing dot, it is always one of the two possible forms. The only alternative is that we always terminate the name with a ., marking it as fully qualified (and violating the expectations of most users) instead. There really isn't an "unqualified name" here either, by the way - this is defined as the DNS domain name of the machine; that isn't a definition that admits "partial domain names". ---------------------------------------- Bug #3909: Strip trailing dots from domain fact https://projects.puppetlabs.com/issues/3909#change-62678 Author: Joe McDonagh Status: In Topic Branch Pending Review Priority: Normal Assignee: Hailee Kenney Category: library Target version: 2.0.0 Keywords: Branch: https://github.com/puppetlabs/facter/pull/200 Affected Facter version: On behalf of a puppet-users posted who did not want to create an additional login to file a bug: I was stumbling over the fact that I use a (not existing) toplevel domain in my environment. So I set up the dnsdomainname to print out the correct domain (without fullstop ('.')). Additional I limited the search path in resolv.conf to end with a '.'. That seems to tangle facter. As I read the code it needs a '.' anywhere in domainname to work and the fallback to parse /etc/resolv.conf cannot handle trailing '.'. The last is easy to handle by $1.sub(/\.$/, '') but the first I do not know how to handle correctly for every case (At least on debian there seems to be '(none)' if it is not defined correctly.) Could that go into upstream code respective how to fix the first case proper? -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
