Issue #12591 has been updated by Andrew  Parker.

Status changed from Unreviewed to Needs Decision


----------------------------------------
Bug #12591: Logrotate not fixed on puppet client.
https://projects.puppetlabs.com/issues/12591#change-62783

Author: Srikrishna Das
Status: Needs Decision
Priority: Normal
Assignee: Matthaus Litteken
Category: 
Target version: 
Affected Puppet version: 
Keywords: puppet, logrotate, sigusr2
Branch: 


Found an update info for > 2.6.4

 [ Stig Sandbeck Mathisen ]
 * debian/puppetmaster.logrotate: send SIGUSR2 on log rotation (Closes:
   #602698 - bugs.debian.org/602698)

this fixes issue that logrotate was using <pre>`/etc/init.d/puppetmaster 
restart`</pre> resulting in all mongrel to be reloaded.

Now, updating to this fix installs a file /etc/logrotate.d/puppetmaster, which 
uses SIGUSR2

but package `puppet` (client) still provides /etc/logrotate.d/puppet which uses 
following snip:
<pre>
  /var/log/puppet/*log {
  missingok
  create 0644 puppet puppet
  compress
  rotate 4

  postrotate
    [ -e /etc/init.d/puppetmaster ] && /etc/init.d/puppetmaster restart 
>/dev/null 2>&1 || true
    [ -e /etc/init.d/puppet ] && /etc/init.d/puppet reload > /dev/null 2>&1 || 
true
  endscript
}
</pre>

causing a duplicate logrotate on server that has both puppetmaster and 
puppetclient.


So,

1. `/etc/init.d/puppetmaster restart` line should probably be removed.
2. and rotate only specific puppet client logs (or exclude masterlog) , rather 
than /var/log/puppet/*log



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to