Issue #13956 has been updated by Josh Cooper.

Status changed from Code Insufficient to In Topic Branch Pending Review
Target version changed from 2.7.15 to 2.7.x
Branch changed from https://github.com/puppetlabs/puppet/pull/708 to 
https://github.com/puppetlabs/puppet/pull/776

Commit <https://github.com/puppetlabs/puppet/commit/64348a0> caused puppet to 
get into an recursive loop when the the win32console gem was not installed and 
running puppet with --debug. Commit #91a4a7d fixed this, but broke the case 
where the gem is installed (due to rubygems not yet being loaded). A new pull 
request has been submitted to get colorized output working again in 2.7.x
----------------------------------------
Feature #13956: Colorize console output on Windows
https://projects.puppetlabs.com/issues/13956#change-62810

Author: Josh Cooper
Status: In Topic Branch Pending Review
Priority: Normal
Assignee: Josh Cooper
Category: windows
Target version: 2.7.x
Affected Puppet version: 2.7.6
Keywords: 
Branch: https://github.com/puppetlabs/puppet/pull/776


Windows consoles do not support ANSI escape sequences, and so Puppet by default 
disables colorizing output (on Windows). However, the win32console gem 
<https://github.com/luislavena/win32console> translates these escape sequences 
into the appropriate native console calls. 

Ken has submitted fixes upstream to fix how foreground and background colors 
are preserved, which is an issue for powershell, since it's default background 
is not black. Now that Ken's fix has been merged, we should move forward with 
colorizing Windows console output by default.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to