Issue #12311 has been updated by Matthaus Litteken.

Status changed from Merged - Pending Release to Closed

Released in facter 2.0.0rc1
----------------------------------------
Bug #12311: Facter::Util::Resolution.with_env should use an "ensure" block
https://projects.puppetlabs.com/issues/12311#change-62946

Author: Chris Price
Status: Closed
Priority: Low
Assignee: Chris Price
Category: 
Target version: 2.0.0
Keywords: 
Branch: https://github.com/puppetlabs/facter/pull/168
Affected Facter version: 


As currently written, if a caller uses a "return" statement from within the 
block that they pass to "with_env", then the code following the "yield" will 
not be excecuted; this results in the environment variables being unexpectedly 
and semi-permanently stomped upon.  The code following the yield could be moved 
inside of an "ensure" block to prevent this issue.

For reference see puppet's version of this method:

 lib/puppet/util/execution.rb , method "withenv".


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to