Issue #13678 has been updated by Hailee Kenney.
We took a look at the pull request, everything looks good. It merged cleaning and all the tests still run. Just waiting to see if anyone has any additional feedback before we merge this into 1.6.x. ---------------------------------------- Refactor #13678: Facter should implement its own which command https://projects.puppetlabs.com/issues/13678#change-63588 Author: Stefan Schulte Status: In Topic Branch Pending Review Priority: Normal Assignee: Category: library Target version: Keywords: Branch: https://github.com/puppetlabs/facter/pull/189 Affected Facter version: Currently `Facter::Util::Resolution.exec` relies on `which` to check if a command can be executed. This basically means that for every command we want to execute, we fork a second time just to execute which. Facter should implement its own which command so we don't need to invoke the shell all the time. Puppet already has some similar methods we may be able to port to facter. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
