Issue #14728 has been updated by Kelsey Hightower. Status changed from Unreviewed to Accepted
I suspect that the changes commands is trying to checksum `xinetd/CHANGELOG` and failing. We should first check if the file exists, and if not report that it's missing. ---------------------------------------- Bug #14728: puppet module changes incorrectly errors when a file is missing https://projects.puppetlabs.com/issues/14728#change-64404 Author: Garrett Honeycutt Status: Accepted Priority: Normal Assignee: Category: module tool Target version: Affected Puppet version: Keywords: Branch: Upon removing a file, CHANGELOG, the following is produced. <pre> Error: No such file or directory - xinetd/CHANGELOG Error: Try 'puppet help module changes' for usage </pre> Instead, this should not error and should output that `xinetd/CHANGELOG` is missing. To reproduce: <pre> [root@puppet modules]# puppet module install ghoneycutt-xinetd Preparing to install into /etc/puppetlabs/puppet/modules ... Downloading from http://forge.puppetlabs.com ... Installing -- do not interrupt ... /etc/puppetlabs/puppet/modules └── ghoneycutt-xinetd (v1.0.1) [root@puppet modules]# rm -f xinetd/CHANGELOG [root@puppet modules]# puppet module changes xinetd Error: No such file or directory - xinetd/CHANGELOG Error: Try 'puppet help module changes' for usage [root@puppet modules]# echo $? 1 </pre> -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
