Issue #14860 has been updated by Jeff McCune.

Bit of background on catching the exception at the interface layer:

<https://groups.google.com/forum/?fromgroups#!topic/puppet-dev/juUl3COIIRg>
----------------------------------------
Bug #14860: Puppet cert generate subcommand does not exit with non-zero status 
when certificate is not created
https://projects.puppetlabs.com/issues/14860#change-64491

Author: Jeff McCune
Status: In Topic Branch Pending Review
Priority: Normal
Assignee: Jeff McCune
Category: SSL
Target version: 2.7.x
Affected Puppet version: 2.7.12
Keywords: cert generate dns_alt_names alternate x509 x.509
Branch: https://github.com/puppetlabs/puppet/pull/839


# Overview #

When using `puppet cert generate foo.example.com --dns_alt_names 
foo,bar,foo.example.com` the command fails but the exit status is 0, indicating 
success.

# Expected Results #

An exit status of 0 should only be returned on successful generation of the 
certificate.

# Actual Results #

When the command fails, the exit status is 0.

# Steps to reproduce #

Given 2.7.12 (Puppet Enterprise 2.5.1)

<pre>
root@pe-centos6:~# puppet cert generate pe-internal-broker-test --dns_alt_names 
stomp,pe-centos6,pe-centos6.puppetlabs.vm
notice: pe-internal-broker-test has a waiting certificate request
err: Could not call generate: CSR 'pe-internal-broker-test' contains subject 
alternative names (DNS:pe-centos6, DNS:pe-centos6.puppetlabs.vm, 
DNS:pe-internal-broker-test, DNS:stomp), which are disallowed. Use `puppet cert 
--allow-dns-alt-names sign pe-internal-broker-test` to sign this request.
root@pe-centos6:~# echo $?
0
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to