Issue #13335 has been updated by Chris Price. Assignee deleted (Chris Price)
---------------------------------------- Refactor #13335: use new "log_and_raise" method https://projects.puppetlabs.com/issues/13335#change-65081 Author: Chris Price Status: Accepted Priority: Low Assignee: Category: error reporting Target version: 3.x Affected Puppet version: Keywords: Branch: Recently, we added a method called "log_exception" to Puppet::Util::Logging in order to try to improve / standardize the way that puppet logs exceptions. However, there were several places in the code where the refactor to use this method still left behind some boilerplate like this: message = "Could not retrieve local facts: #{detail}" Puppet.log_exception(detail, message) raise Puppet::Error, message In pull request 571 ( https://github.com/puppetlabs/puppet/pull/571 ), I added a new "log_and_raise" method which can be used to eliminate this boilerplate; however I haven't yet swept through the code base to switch things over to actually use it. We should do that. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
