Issue #15032 has been updated by Patrick Ringl.

Hey namesake ;-) ..

.. yes, in fact I did .. and yes the way you see it is correct - yet this is 
not the way it is supposed to be. Imho dpkg-query needs the extra quotations 
not for simple argument separation but for pinpointing the to-be-parsed 
beginning and ending of the showformat-stmt.

The point is, this will not lead to anything that can be rescued, since *not* 
encapsulating the showformat-stmt in quotes will not necessarily lead to an 
exit_code>0!


regards,
Patrick
----------------------------------------
Bug #15032: dpkg.rb - provider.query partly broken
https://projects.puppetlabs.com/issues/15032#change-65417

Author: Patrick Ringl
Status: Unreviewed
Priority: Normal
Assignee: 
Category: provider
Target version: 
Affected Puppet version: development
Keywords: 
Branch: 


Hi,

imho the 'query'-method of the 'dpkg'-provider is broken - see the attached 
patch.


regards,
Patrick

    ---
    Signed-off-by: Patrick Ringl <[email protected]>
    diff --git a/lib/puppet/provider/package/dpkg.rb 
b/lib/puppet/provider/package/dpkg.rb
    index 178a8f2..0d5d498 100755
    --- a/lib/puppet/provider/package/dpkg.rb
    +++ b/lib/puppet/provider/package/dpkg.rb
    @@ -105,7 +105,7 @@ Puppet::Type.type(:package).provide :dpkg, :parent => 
Puppet::Provider::Package
        output = dpkgquery(
            "-W",
            "--showformat",
    -        '${Status} ${Package} ${Version}\\n',
    +        "'${Status} ${Package} ${Version}\\n'",
            @resource[:name]
        )
        rescue Puppet::ExecutionFailure
    ---



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to