Issue #14909 has been updated by Will Hopper.

Status changed from Accepted to In Topic Branch Pending Review

Tested, and pull request at:
https://github.com/puppetlabs/puppet-community-debian/pull/12
----------------------------------------
Bug #14909: createpackage.sh should pass --no-recommend flag to packagemaker
https://projects.puppetlabs.com/issues/14909#change-65532

Author: Clay Caviness
Status: In Topic Branch Pending Review
Priority: Normal
Assignee: Will Hopper
Category: OSX
Target version: 
Affected Puppet version: 
Keywords: packaging
Branch: 


Currently, this flag is not passed. This is a bit tricky - packagemaker will 
helpfully apply the permissions it finds on the system if one of the files in 
the payload exists on the disk, rather than the ones carefully set up in the 
package root.

This means that if you started using puppet a long time ago (like me...) when 
the Mac package installed group-writable files, any package built after 
upstream puppet fixed those permissions will instead use your local broken 
permissions and create a package with files that have group-writable perms.

To work around this, in create_package() in createpackage.sh, change the call 
to packagemaker to:
<pre>
  "${PACKAGEMAKER}" --verbose --no-recommend --no-relocate \
                    --root "${pkgroot}" \
                    --info "${pkgtemp}/${PROTO_PLIST}" \
                    --scripts ${pkgtemp}/scripts \
                    --out "$(pwd)/puppet-${puppet_version}.pkg"
</pre>

It's probably a good idea to add `chmod -R go-w "${pkgroot}"` to the end of 
install_puppet() as well.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to