Issue #4111 has been updated by Daniel Pittman.

Thomas Linkin wrote:
> Branch: https://github.com/puppetlabs/puppet/pull/872

As I commented on the pull request:

I think this is a mistake: it adds a huge amount of complexity to the model, 
and doesn't really address the problem.

A much better strategy would be to sync the `ensure` property, then check which 
other properties are out of sync and update those.

That has zero user facing complexity, results in the assurance that a resource 
is fully in sync after a Puppet run, and is absolutely transparent - it fixes 
all the existing types.

(Additionally, it has the virtue that it is not a "don't be stupid" switch - 
this is a switch to say "don't be stupid about fixing problems with this 
property", which probably should apply to almost every single property of every 
single resource.)

I would be much more inclined to accept a special switch for "don't sync this 
attribute" rather than "do sync this attribute".
----------------------------------------
Bug #4111: If "ensure" changes, then no other changes are reported for that 
resource.
https://projects.puppetlabs.com/issues/4111#change-65552

Author: Dan Bode
Status: In Topic Branch Pending Review
Priority: High
Assignee: 
Category: service
Target version: 
Affected Puppet version: 
Keywords: 
Branch: 


code:
<pre>
service { 'httpd':
  ensure => running,
  enable => true,
}
</pre>

even though chkconfig is set to off in both cases, its only logged when the 
process isn't started.

<pre>
# /sbin/service httpd stop
Stopping httpd:                                            [  OK  ]
[root@dannyboy manifests]# chkconfig httpd off
[root@dannyboy manifests]# puppet myservice.pp 
notice: //Service[httpd]/ensure: ensure changed 'stopped' to 'running'
[root@dannyboy manifests]# chkconfig httpd off
[root@dannyboy manifests]# puppet myservice.pp 
notice: //Service[httpd]/enable: enable changed 'false' to 'true'
[root@dannyboy manifests]# 
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to